Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QWaveComboBox does not save current text correctly upon wave deletion #43

Open
bbreslauer opened this issue Jun 1, 2011 · 0 comments
Open
Assignees
Labels

Comments

@bbreslauer
Copy link
Owner

If you have a QWaveComboBox selected to a wave, and an entry above that one in the box is deleted, then selected one becomes the wave below the one that was previously selected. This is because the model's data is updated before calling reset, and so by the time QWaveComboBox.beforeReset is called, the model's data has already changed.

Example:
Before:
Wave1
Wave2 <-- to be deleted
Wave3 <-- selected
Wave4

After:
Wave1
Wave3
Wave4 <-- selected

@ghost ghost assigned bbreslauer Jun 1, 2011
bbreslauer added a commit that referenced this issue Jun 1, 2011
…(otherwise the combo boxes are reset and the selected names cannot be retrieved). Moved output wave creation to doFit instead of the individual fitting methods, because it will be common to all the fitting methods. Created a QWaveComboBox to deal with keeping the current item current even if the model is reset. The naming of this might be changed in the future; I haven't decided. This created issue #43, where it is sometimes 1 off from the correct current item.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant