Config file does not allow nested stringify functions

[bbyars]

See https://groups.google.com/forum/#!topic/mountebank-discuss/6ShnSHx-GAc

and

https://gist.github.com/zot24/3cf6df65c8ae3e63c2deabc4ed7174b9

[bbyars]

Fixed in 0e02d68

[rohgoyal]

hey Brandon, I am still facing this issue. Nested stringily failing for me with error something like this

{
	"errors": [{
		"code": "invalid injection",
		"message": "invalid response injection",
		"source": "(function (request, state, logger) {\n    logger.info('apiStub.ejs Called');\n    var apiKey = request.method + '-' + request.path;\n    logger.info(apiKey);\n    return {\n      headers: {\n        'Content-Type': 'application/json'\n      },\n      body: JSON.stringify({ count: 10 }\\n)\n    };\n}\n)(scope, injectState, logger, deferred.resolve, imposterState);",
		"data": "Invalid or unexpected token",
		"name": "Error",
		"stack": "Error\n    at Object.from (/usr/local/lib/node_modules/mountebank/src/util/inherit.js:15:17)\n    at createError (/usr/local/lib/node_modules/mountebank/src/util/errors.js:10:26)\n    at Object.InjectionError (/usr/local/lib/node_modules/mountebank/src/util/errors.js:25:16)\n    at inject (/usr/local/lib/node_modules/mountebank/src/models/responseResolver.js:43:44)\n    at processResponse (/usr/local/lib/node_modules/mountebank/src/models/responseResolver.js:237:20)\n    at Object.resolve (/usr/local/lib/node_modules/mountebank/src/models/responseResolver.js:271:16)\n    at Object.resolve (/usr/local/lib/node_modules/mountebank/src/models/stubRepository.js:124:18)\n    at F.respond (/usr/local/lib/node_modules/mountebank/src/models/http/baseHttpServer.js:78:34)\n    at /usr/local/lib/node_modules/mountebank/src/models/abstractServer.js:96:35\n    at _fulfilled (/usr/local/lib/node_modules/mountebank/node_modules/q/q.js:854:54)"
	}]
}

[rohgoyal]

Btw, this is how you can recreate the problem
$mb --configfile templates/originServer.ejs --allowInjection

templates/originServer.ejs

{
  "port": 5555,
  "protocol": "http",
  "name": "origin",
  "stubs": [
    {
      "responses": [{ "inject": "<%- stringify(filename, 'apiStub.ejs') %>" }]
    }
  ]
}

templates/apiStub.ejs

function (request, state, logger) {
    logger.info('apiStub.ejs Called');
    var apiKey = request.method + '-' + request.path;
    logger.info(apiKey);
    return {
      headers: {
        'Content-Type': 'application/json'
      },
      body: JSON.stringify(<%- stringify(filename, 'GET-request.ejs') %>)
    };
}

templates/GET-request.ejs
{ count: 10 }

[bbyars]

What version of mountebank are you using? mb --version Also, I'm assuming you get the error on startup, correct? Assuming that's the case, I couldn't reproduce with the latest version, so I imagine the problem is that you're simply on an older version. -Brandon

…

On Thu, Sep 21, 2017 at 7:38 AM, Rohit ***@***.***> wrote: Btw, this is how you can recreate the problem $mb --configfile templates/originServer.ejs --allowInjection templates/originServer.ejs { "port": 5555, "protocol": "http", "name": "origin", "stubs": [ { "responses": [{ "inject": "<%- stringify(filename, 'apiStub.ejs') %>" }] } ] } templates/apiStub.ejs function (request, state, logger) { logger.info('apiStub.ejs Called'); var apiKey = request.method + '-' + request.path; logger.info(apiKey); return { headers: { 'Content-Type': 'application/json' }, body: JSON.stringify(<%- stringify(filename, 'GET-request.ejs') %>) }; } templates/GET-request.ejs { count: 10 } — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#183 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAESvyMs5ZteLaT5obZZdLR2naJQCMd7ks5skliygaJpZM4LYwn7> .

[rohgoyal]

Hi Brendan, I get this error when I call the port 5555, instead startup.
Here is what I am running on my laptop
~ $mb --version
1.12.0

[bbyars]

Thanks for the extra info. I identified the bug and fixed it - it has to do with an extra newline at the end of the nested stringify funciton. I aim to release the next version this week.

…

On Sun, Sep 24, 2017 at 6:30 AM, Rohit ***@***.***> wrote: Hi Brendan, I get this error when I call the port 5555, instead startup. Here is what I am running on my laptop ~ $mb --version 1.12.0 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#183 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAESv0nwXuDCLsursno19t9Zr61C6lxDks5slj1EgaJpZM4LYwn7> .

[leogtzr]

Hi Brendan, has this been fixed? I am facing the same issue, I am able to replicate the issue with @rohgoyal imposter and ejs file.

I am using 1.14.1

Thanks!

[bbyars]

Hi @leogtzr. Interesting...I can't reproduce it. I thought I fixed it in v1.13.0 (see #293 and the corresponding commit). A local test using @rohgoyal 's files works for me, returning a body of "{"count":10}" when calling the imposter on port 5555, and logging the "apiStub.ejs Called".

What O/S are you using?

[leogtzr]

Hello, sorry for the late response: I am currently using: [0 [17:26][leo@~]$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 18.04 LTS Release: 18.04 Codename: bionic [0 [17:26][leo@~]$ I will see if I can reproduce it this weekend and send you over the files. Thank you! El lun., 4 jun. 2018 a las 14:05, Brandon Byars (<notifications@github.com>) escribió:

…

Hi @leogtzr <https://github.com/leogtzr>. Interesting...I can't reproduce it. I thought I fixed it in v1.13.0 (see #293 <#293> and the corresponding commit). A local test using @rohgoyal <https://github.com/rohgoyal> 's files works for me, returning a body of "{"count":10}" when calling the imposter on port 5555, and logging the "apiStub.ejs Called". What O/S are you using? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#183 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABJ-QTZcBYV061U63pUPmROeiY58Zslwks5t5ZMAgaJpZM4LYwn7> .

-- * Leonardo Gutiérrez R.*

[bbyars]

OK thanks, keep me posted.

…

On Fri, Jun 8, 2018 at 6:27 PM, Leo Gutiérrez Ramírez < ***@***.***> wrote: Hello, sorry for the late response: I am currently using: [0 [17:26][leo@~]$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 18.04 LTS Release: 18.04 Codename: bionic [0 [17:26][leo@~]$ I will see if I can reproduce it this weekend and send you over the files. Thank you! El lun., 4 jun. 2018 a las 14:05, Brandon Byars ***@***.*** >) escribió: > Hi @leogtzr <https://github.com/leogtzr>. Interesting...I can't reproduce > it. I thought I fixed it in v1.13.0 (see #293 > <#293> and the corresponding > commit). A local test using @rohgoyal <https://github.com/rohgoyal> 's > files works for me, returning a body of "{"count":10}" when calling the > imposter on port 5555, and logging the "apiStub.ejs Called". > > What O/S are you using? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#183 (comment) >, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABJ- QTZcBYV061U63pUPmROeiY58Zslwks5t5ZMAgaJpZM4LYwn7> > . > -- * Leonardo Gutiérrez R.* — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#183 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAESvxhsiYZQnQshRQPcg4Kt3hl7XlV5ks5t6whhgaJpZM4LYwn7> .