Fix Internal Server Error (500) if predicate attributes have null value. #53
Conversation
After upgrading to node v.0.11.14, attributes passed to predicate
operators could have null values. In that case, NullPointerException is
thrown and HTTP error 500 is returned.
Test cases:
* *query* attribute is missing in HTTP call, while it is expected in predicate:
curl -X DELETE http://localhost:4545/customer
"equals": {
"method": "DELETE",
"path": "/customer",
"query": {
"id": "1001"
}
}
* *query* attribute is not expected in predicate and is not provided in HTTP call:
curl -X PUT -d@data.json http://localhost:4545/customer
"equals": {
"method": "PUT",
"path": "/customer"
}
Fix Internal Server Error (500) if predicate attributes have null value.
|
Good catch - thanks again |
|
Brandon, what do you think about adding functionality to return HTTP 404 if Regards, On 5 November 2014 14:46, Brandon Byars notifications@github.com wrote:
|
|
Hi - sorry for the slow response (swamped at work). It's definitely a tradeoff, but I think I prefer leaving the 200 because one of my goals was to have as many of the imposter elements as possible be optional and have reasonable defaults. It's possible, for example, to have stubs but no predicates because predicates simply don't matter for your scenario because the system under test only calls the web service once in a well known way, and predicates would just complicate the test setup. Thanks for the idea, and please keep sending them! |
|
I see, but if you have stub without predicates it will much. So there is no /Robert On 7 November 2014 16:46, Brandon Byars notifications@github.com wrote:
|
After upgrading to node v.0.11.14, attributes passed to predicate
operators could have null values. In that case, NullPointerException is
thrown and HTTP error 500 is returned.
Test cases:
query attribute is missing in HTTP call, while it is expected in predicate:
curl -X DELETE http://localhost:4545/customer
"equals": {
"method": "DELETE",
"path": "/customer",
"query": {
"id": "1001"
}
}
query attribute is not expected in predicate and is not provided in HTTP call:
curl -X PUT -d@data.json http://localhost:4545/customer
"equals": {
"method": "PUT",
"path": "/customer"
}