fix: adjust imposter metrics creation (#1) #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: change metric creation to inside of imposters module * refactor: use object metrics in memory * refactor: use Boolean class to convert object to boolean * refactor: adjust eslint appointments * test: ensure Metrics only return imposter metrics only if a imposter exists * test: ensure Metrics only return imposter metrics only if a imposter was called * test: ensure Metrics returns imposter metrics after imposters calls
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use mountebank to run load tests, because of that, I use the imposter metrics to get feedback about the time to generate the responses. After the release 2.8.1 the metrics about imposters stop showing. The reason is, the module imposter.js started to be loaded before the method prometheus.register.clear(); to be called. I created a method to create the metrics inside the function create and an object to control if metrics already created.
fix #718