feat: use strum to better manage string enums

[bc-m]

Thanks to @jwillinghalpern for this idea in jwillinghalpern@3e919c7.

[jwillinghalpern]

Hey, it probably doesn't really matter either way, but I also played with an even less noisy way using the FromRepr feature of strum to make the code even less noisy. But it has the downside of not being able to (directly) associate multiple strings directly with the Unknown variant, if that's required. The from id function can still handle unknown ids and route them to Unkown though.

jwillinghalpern@f9e263c

[bc-m]

Hey, it probably doesn't really matter either way, but I also played with an even less noisy way using the FromRepr feature of strum to make the code even less noisy. But it has the downside of not being able to (directly) associate multiple strings directly with the Unknown variant, if that's required. The from id function can still handle unknown ids and route them to Unkown though.

jwillinghalpern@f9e263c

I like, thats a way less noisy! Actually, the script step ids for unknown script steps don't matter at all. I just used the enum to keep track of them because it was easy. I would also be fine with keeping the known step ids of unknown steps in a separate list and handle them in "from id" as you suggested.