Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

self.applyZoom fix - #29 #31

Merged
merged 1 commit into from Mar 15, 2016
Merged

self.applyZoom fix - #29 #31

merged 1 commit into from Mar 15, 2016

Conversation

KarlDoyle
Copy link
Contributor

@bcabanes

#29

Applied fix suggested by bigfree in the issue above.

previous

this.elements.controls.zoomIn.addEventListener('click', function() {
    self.applyZoom(self.zoomInFactor);
});
this.elements.controls.zoomOut.addEventListener('click', function() {
    self.applyZoom(self.zoomOutFactor);
});

changed to

this.elements.controls.zoomIn.addEventListener('click', function() {
    self.applyZoomIn(self.zoomInFactor);
});
this.elements.controls.zoomOut.addEventListener('click', function( {
    self.applyZoomOut(self.zoomOutFactor);
});

@KarlDoyle KarlDoyle changed the title Resolved - #29 self.applyZoom self.applyZoom fix - #29 Mar 14, 2016
@codecov-io
Copy link

Current coverage is 78.63%

Merging #31 into master will not affect coverage as of ac8ad62

@@            master     #31   diff @@
======================================
  Files            7       7       
  Stmts          454     454       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            357     357       
  Partial          0       0       
  Missed          97      97       

Review entire Coverage Diff as of ac8ad62

Powered by Codecov. Updated on successful CI builds.

@bcabanes bcabanes self-assigned this Mar 15, 2016
bcabanes added a commit that referenced this pull request Mar 15, 2016
@bcabanes bcabanes merged commit f5f6fb4 into bcabanes:master Mar 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants