Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG]: $reset triggers orphaned edge errors #834

Closed
1 task done
Tracked by #835
snoozbuster opened this issue Apr 1, 2023 · 0 comments · Fixed by #838
Closed
1 task done
Tracked by #835

🐛 [BUG]: $reset triggers orphaned edge errors #834

snoozbuster opened this issue Apr 1, 2023 · 0 comments · Fixed by #838
Assignees
Labels
bug Something isn't working

Comments

@snoozbuster
Copy link
Contributor

snoozbuster commented Apr 1, 2023

Is there an existing issue for this?

  • I have searched the existing issues and this is a new bug.

Current Behavior

If you call $reset with a graph that has edges in the state, the @error event is emitted with an orphaned edge error for each removed edge.

Expected Behavior

$reset should reset the state without errors

Steps To Reproduce

Click reset in this sandbox and observe the console errors

Relevant log output

No response

Anything else?

This can be worked around by calling removeEdges(unref(getEdges)) before $reset (as long as all edges are deletable or made deletable beforehand). It seems like maybe the code internally just processes nodes before edges?

@snoozbuster snoozbuster added bug Something isn't working triage Awaiting triage labels Apr 1, 2023
@bcakmakoglu bcakmakoglu removed the triage Awaiting triage label Apr 2, 2023
@bcakmakoglu bcakmakoglu linked a pull request Apr 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants