Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types,flow)!: Use reactivity transform and remove store property #111

Merged
merged 28 commits into from
Apr 22, 2022

Conversation

bcakmakoglu
Copy link
Owner

What's changed?

  • Remove store property from usevueflow return value
  • All previously available properties are still there, just not nested inside an additional store object to avoid confusion + duplicates
  • use reactivity transform to get rid of .value calls

# What's changed?

* Dispose prop watcher effects and event bindings when vue flow is unmounted/its scope is disposed
# What's changed?

* Remove keys
* Stabilize props
* Force reset store on unmount
# What's changed?

* Use controlled computed properties in Minimap to improve performance
# What's changed?

* Change base edge into a functional component (doesn't need a state)
* Export base edge for convenience
# What's changed?

* Remove base-edge component for performance
# What's changed?

* Change default node/edge components to functional components
# What's changed?

* use explicit types for actions and export those
* add comments
…erty

# What's changed?

* Remove store property from usevueflow return value
* All previously available properties are still there, just not nested inside an additional store object to avoid confusion + duplicates
* use reactivity transform to get rid of .value calls
@vercel
Copy link

vercel bot commented Apr 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

vue-flow-typedoc – ./

🔍 Inspect: https://vercel.com/bcakmakoglu/vue-flow-typedoc/ETQ3ihmYmi1MnAApngWptscWkh3j
✅ Preview: Failed

[Deployment in progress for a25179e]

vue-flow-docs – ./

🔍 Inspect: https://vercel.com/bcakmakoglu/vue-flow-docs/u1jfVnABhViuAgjheDfVWTtNszay
✅ Preview: Failed

[Deployment in progress for a25179e]

@bcakmakoglu bcakmakoglu self-assigned this Apr 22, 2022
@bcakmakoglu bcakmakoglu added refactor Refactor existing features patch labels Apr 22, 2022
@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc April 22, 2022 12:28 Inactive
@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc April 22, 2022 12:37 Inactive
@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc April 22, 2022 14:34 Inactive
@bcakmakoglu bcakmakoglu marked this pull request as ready for review April 22, 2022 14:34
@bcakmakoglu bcakmakoglu added the performance Improve performance of an existing feature label Apr 22, 2022
@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc April 22, 2022 15:01 Inactive
@bcakmakoglu bcakmakoglu merged commit 3654e2e into develop Apr 22, 2022
@bcakmakoglu bcakmakoglu deleted the refactor/reactivity-transform branch April 22, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Improve performance of an existing feature refactor Refactor existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant