Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Add EdgeLabelRenderer component export #361

Merged
merged 2 commits into from
Nov 4, 2022
Merged

feat(core): Add EdgeLabelRenderer component export #361

merged 2 commits into from
Nov 4, 2022

Conversation

bcakmakoglu
Copy link
Owner

@bcakmakoglu bcakmakoglu commented Oct 18, 2022 •
edited
Loading

🚀 What's changed?

  • Add EdgeLabelRenderer component export
    • Allows rendering edge labels as regular HTMLElements instead of SVGElements

🐛 Fixes

  • Edge labels overlapped by edges and other labels (in order of edges in DOM)

@bcakmakoglu bcakmakoglu added the bug Something isn't working label Oct 18, 2022
@bcakmakoglu bcakmakoglu self-assigned this Oct 18, 2022
@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 221dc52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-flow/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 18, 2022

Deployment failed with the following error:

Resource is limited - try again in 9 hours (more than 100, code: "api-deployments-free-per-day").

@vercel
Copy link

vercel bot commented Nov 3, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
vue-flow-docs ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 8:03PM (UTC)
vue-flow-typedoc ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 8:03PM (UTC)

@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc November 3, 2022 07:42 Inactive
@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc November 4, 2022 07:38 Inactive
@bcakmakoglu bcakmakoglu marked this pull request as ready for review November 4, 2022 10:08
@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc November 4, 2022 10:10 Inactive
@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc November 4, 2022 16:56 Inactive
@bcakmakoglu bcakmakoglu changed the title fix(edges): teleport edge text into separate container feat(core): Add EdgeLabelRenderer component export Nov 4, 2022
@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc November 4, 2022 20:01 Inactive
@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc November 4, 2022 20:03 Inactive
@bcakmakoglu bcakmakoglu merged commit a26e83b into master Nov 4, 2022
@bcakmakoglu bcakmakoglu deleted the fix/edge-label-container branch November 4, 2022 21:10
This was referenced Nov 4, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bcakmakoglu bcakmakoglu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bcakmakoglu