Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pretty stacktrace: catch uncaught exception on node internal files #479

Merged
merged 1 commit into from Apr 24, 2020

Conversation

bcaudan
Copy link
Owner

@bcaudan bcaudan commented Apr 24, 2020

What is the current behavior?

On exception involving node internal files, the stacktrace does not provide the full path which then crash the reporter.

What is the new behavior?

Catch exception and display an error message

fix #478

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #479 into master will decrease coverage by 0.20%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #479      +/-   ##
===========================================
- Coverage   100.00%   99.80%   -0.21%     
===========================================
  Files           16       16              
  Lines          498      500       +2     
  Branches        69       69              
===========================================
+ Hits           498      499       +1     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/processors/pretty-stacktrace-processor.ts 97.56% <66.66%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d75ad3...e1d24e1. Read the comment docs.

@bcaudan bcaudan merged commit 9058e6a into master Apr 24, 2020
@bcaudan bcaudan deleted the fix-prettify-issue-on-node-files branch April 24, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught exception when using displayStacktrace: 'pretty' option
1 participant