WIP: Improving the Grid to support reading k and Fourier resampling #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this works. Need to read through the logic again. What a headache to write this!
Need to check the freaking output.
Up is still a wreck.
Still need to sort the src first. We may be able to get around with some of these reordering tricks. But it fries my poor brain to think about these permutations!
Making them test cases!
We don't have a Fourier space PaintGrid yet. But the output format shall be compatible when we write it up. This needs some additional testing. LinearDensityK is supposed to be 1 + delta. I am not sure the units of DensityK.
|
I think this is ready for use. @nickhand could you take a look? |
writing a Fourier grid is not tested but it should work ...
|
It will need the new version of mpsort (0.1.8) that I have just tagged. |
These shall probably go into the painter ... But the transfer function syntax we currently have looks more clumsy that this..
|
I liked normalize, frho and fk functions in bf209a9 . Could it be an easier replacement than those giant ugly transfer functions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.