Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset tests #327

Merged
merged 3 commits into from
Apr 6, 2017
Merged

Dataset tests #327

merged 3 commits into from
Apr 6, 2017

Conversation

nickhand
Copy link
Member

@nickhand nickhand commented Apr 6, 2017

No description provided.

@nickhand
Copy link
Member Author

nickhand commented Apr 6, 2017

@rainwoodman - what are your thoughts on including small test data files in a "data" directory in the test directories, if needed? I think as long as we keep them small, this is cleaner than any other solutions

I've included a few small power spectra result files in nbodykit/tests/data to test DataSet properly

@rainwoodman
Copy link
Member

Yes. I agree. Paths will be hard. Are we sure python always install package data to the relative location -- or does some distributions move package data to /usr/share?

Also, I don't remember if you also need to add the directory to MANIFEST file in order to properly build a source tarball.

@rainwoodman
Copy link
Member

Looks like the path is safe: (installing data to /usr/share has been disabled) http://stackoverflow.com/a/13476594. I am still not so sure about MANIFEST.in.

@nickhand
Copy link
Member Author

nickhand commented Apr 6, 2017

It looks like you do not need to include them in a MANIFEST.in for 2.7+

http://stackoverflow.com/questions/7522250/how-to-include-package-data-with-setuptools-distribute

I've confirmed running sdist includes them. Will merge now

@nickhand nickhand merged commit 561795c into bccp:master Apr 6, 2017
@nickhand nickhand deleted the dataset-tests branch April 6, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants