save source attrs as JSON string representation (#328) #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest still make best attempt to write the attrs to the header. That's more readable than the json encoding. What about only collect those that failed into json? |
|
How would we detect if attributes will fail? I think BigFile succeeds in writing them to file...it is only when we read them back in BigFileCatalog that we discover that some are actually nonsense |
|
What if bigfile fails immediately trying to assign object array to an attr? |
…s Quantity.value (no units)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the most straightforward short-term solution to #328. Use
nbodykit.utils.JSONEncoderto simply write out the JSON string in the BigFile