add a cached halotools catalogs + HOD cleanup

[nickhand]

A few additions:

• HalotoolsCachedCatalog can download + load the built-in halo sims available through Halotools. They seem to be a good size for tutorials (~100 MB) and are useful for comparing 2-pt correlation function results to halotools results
• Support for astropy Table in ArrayCatalog
• re-organize HODCatalog a bit so it subclasses HalotoolsMockCatalog, with can populate a mock in parallel given a Halotools catalog + model. This adds support for generic Halotools models.
• catch and re-raise exceptions when populating mocks with only the root rank. This should prevent the code from hanging and Halotools is pretty good about having useful exception messages.

[nickhand]

@rainwoodman I am ready to merge this now, if you are.

[rainwoodman]

Because?

[nickhand]

logMmin is very large. I'll add a note

[rainwoodman]

do you like hod.repopulate() better than halos.repopulate()?

[rainwoodman]

If that's the case then the first ValueError can be eliminated -- without doing populate first there is no hod object for you to repopulate.

The implication is that the compiled model shall be associated with hod, not halos.

[rainwoodman]

Probably give an explicit seed ? It is unlikely but what if random number generator just gave the same number as you used?

[nickhand]

I am actually testing that the seed is set by root and then propagated when it is None − I'll update the assertion

[rainwoodman]

typo: TPM, not Gadget1P

[rainwoodman]

I noted a few minor glitches in the comments.

hod.repopulate() and halo.populate() can the assertion no repopluate before populate. It encourages moving the compiled model to hod -- but I suspect this works against the data model of halotools. We can still mark halo._repopulate() private and only expose it via hod.repopulate(), then comment about the reason for using a delegation .

[nickhand]

Okay, I agree with your repopulate() comment. Now, halos.populate returns a PopulatedHaloCatalog (a light subclass of ArrayCatalog) which has the repopulate() method (which does the repopulation in place).

I'll merge this if you are ready.

[rainwoodman]

Yes looks good!

…

On Nov 18, 2017 10:10 AM, "Nick Hand" ***@***.***> wrote: Okay, I agree with your repopulate() comment. Now, halos.populate returns a PopulatedHaloCatalog (a light subclass of ArrayCatalog) which has the repopulate() method (which does the repopulation in place). I'll merge this if you are ready. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#441 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIbTMkxnTuBxJUIITTO_LLS0MbN3Ny5ks5s3x19gaJpZM4QWjiz> .