Update fof.py #611
Merged
Update fof.py #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some source like the `Gadget1Catalog` does not have an Nmesh attribute
rainwoodman
reviewed
Feb 9, 2020
|
Why not including ndim in the attributes of catalog and mesh sources? |
|
I think it is because if the catalog doesn't define a Position, then ndim is not defined. How did you test this? |
|
Is there any example of catalog without 'Position'? And should we move these ndim inference lines to the source class? |
|
Without 'Position': Galaxy catalog with RA and DEC. We probably shouldn't move the ndim inference lines to the source class: one-liner functions that are sometimes defined sometimes not defined is likely not worthy of the complexity. I think we may already have a few of these, and they are awkward. |
|
Merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some source like the
Gadget1Catalogdoes not have an Nmesh attribute