Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the way RSD is added to positions #645

Merged
merged 16 commits into from
Oct 20, 2020
Merged

Fix the way RSD is added to positions #645

merged 16 commits into from
Oct 20, 2020

Conversation

eelregit
Copy link
Member

@eelregit eelregit commented Oct 14, 2020

To address #644

@eelregit eelregit marked this pull request as ready for review October 15, 2020 00:29
@eelregit
Copy link
Member Author

eelregit commented Oct 15, 2020

@rainwoodman

  • Could you change it to use dask?
  • Is there difference between creating a pull request using github web interface (surprised that I have the permission to make a new branch here) vs fork it to my repository first?

@eelregit
Copy link
Member Author

CI got stuck because my non-dask code?

nbodykit/transform.py Outdated Show resolved Hide resolved
@rainwoodman
Copy link
Member

This looks good to me. Shall we merge?

We shall make a release, then also update the examples at https://github.com/bccp/nbodykit-cookbook.

@eelregit
Copy link
Member Author

I clicked merge and learned afterwards that the commits were not squashed.
Sorry! How to fix that?
Also changed a line in the cookbook.

@eelregit
Copy link
Member Author

@rainwoodman Should I revert and then squash merge?

@rainwoodman
Copy link
Member

rainwoodman commented Oct 21, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants