Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sscan scatter plot has no data #45

Closed
prjemian opened this issue Mar 18, 2020 · 14 comments
Closed

sscan scatter plot has no data #45

prjemian opened this issue Mar 18, 2020 · 14 comments
Assignees
Labels
bug Something isn't working

Comments

@prjemian
Copy link
Contributor

expected data not shown in the scatter plot from the sscan screen

  • upper: PyDM
  • lower: MEDM

Clipboard01

@prjemian prjemian added the bug Something isn't working label Mar 18, 2020
@prjemian prjemian added this to the initial release milestone Mar 18, 2020
@prjemian prjemian self-assigned this Mar 18, 2020
@prjemian
Copy link
Contributor Author

Detector PV did not connect. Macros?
Clipboard01

@prjemian
Copy link
Contributor Author

One problem: $() should use curly braces: ${}

Not the real problem, though. The *PV addresses are connected while the *CA addresses are not. Unexpanded macros?

@prjemian
Copy link
Contributor Author

Also expand macros in the yLabels (and xLabels)

@prjemian
Copy link
Contributor Author

All channels connect, still no data:
Clipboard01

@prjemian
Copy link
Contributor Author

prjemian commented Mar 18, 2020

Of course! The data here are waveforms so we need to be using the PyDMWaveformPlot widget instead.

How can a screen translator be smart enough to know this a priori? MEDM handles both scaler PVs and waveform PVs from the same cartesian plot widget.

@hhslepicka, @mattgibbs , @timmmooney: Any insight how a display screen translator can decide if given PVs come from a waveform PV (so need to use the PyDMScatterPlot widget) or a scalar PV (need to use the PyDMScatterPlot widget)?

@prjemian
Copy link
Contributor Author

This would be easy if the translator had access to an IOC with those PVs available. Since the translators run in an automation (likely even in CI), can't count on an IOC to be available.

@prjemian
Copy link
Contributor Author

@MarkRivers : Might you have some ideas how to resolve the problem here?

@MarkRivers
Copy link

MEDM handles both scaler PVs and waveform PVs from the same cartesian plot widget.

I think I've only used it with waveform PVs. How does it handle scaler PVs?

@prjemian
Copy link
Contributor Author

prjemian commented Mar 18, 2020 via email

@prjemian
Copy link
Contributor Author

not a section, that's a table - very detailed explanation there

@prjemian
Copy link
Contributor Author

I'm thinking that we'll probably need a new plotting widget in PyDM (for compatibility with MEDM screens) that provides this capability. Until then, the translator should default to PyDMWaveformPlot instead of PyDMScatterPlot.

@prjemian
Copy link
Contributor Author

Switching (manual edit) to the PyDMWaveformPlot widget, the plot data shows and is the same as MEDM
Clipboard01

prjemian added a commit that referenced this issue Mar 18, 2020
@MarkRivers
Copy link

Until then, the translator should default to PyDMWaveformPlot instead of PyDMScatterPlot.

I agree, I think the Cartesian plot is used much more with waveforms than scalers.

Since most windows have at most one plot window (or if there is more than one they are usually all the same type) then you could have a command line option for the translator that tells it to use PyDMScatterPlot rather than the default PyDMWaveformPlot.

@prjemian
Copy link
Contributor Author

Good suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants