Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make this package installable by pip #150

Closed
wants to merge 8 commits into from
Closed

make this package installable by pip #150

wants to merge 8 commits into from

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added the task routine work label Aug 26, 2023
@prjemian prjemian added this to the v1.0.0 milestone Aug 26, 2023
@prjemian prjemian self-assigned this Aug 26, 2023
rodolakis
rodolakis requested changes Aug 26, 2023
View reviewed changes
Copy link
Collaborator

@rodolakis rodolakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add catalog in the keyword. It looks good to me however I'd like you to walk me through the process sometime next week. There is going to be a lot of conflict with the PRs I put in yesterday though, how are you going to resolve that?

pyproject.toml Show resolved Hide resolved
@rodolakis rodolakis self-requested a review August 26, 2023 19:53
@prjemian
Copy link
Contributor Author

Knew this would be some trouble. I'm working through those now. Time to improve my skills, it seems. Might be better to push the other PRs through before I try to resolve the merge conflicts.

@rodolakis
Copy link
Collaborator

There is only one left, and I submitted it back for review. It was just formatting so it should not take long/.

@rodolakis
Copy link
Collaborator

rodolakis commented Aug 26, 2023 •
edited

Knew this would be some trouble. I'm working through those now. Time to improve my skills, it seems. Might be better to push the other PRs through before I try to resolve the merge conflicts.

All good, good luck with that!

@prjemian
Copy link
Contributor Author

Easier to start over than manage the various conflicts. I'll add catalog to the keywords.

@prjemian prjemian closed this Aug 26, 2023
@prjemian prjemian deleted the 98-installable-package branch August 26, 2023 20:24
@prjemian
Copy link
Contributor Author

See #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodolakis rodolakis Awaiting requested review from rodolakis

Assignees

@prjemian prjemian

Labels
task routine work
Projects
GemViz initial release
Status: Done
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

packaging - create an installable version of the software
2 participants
@prjemian @rodolakis