ECUtil.getCurveName() does not recognize Ed25519 curves

[vanitasvitae]

When calling

ECPublicBCPGKey key = ... // generate/load PGP key based on Ed25519
ASN1ObjectIdentifier identifier = key.getCurveOID(); // "1.3.6.1.4.1.11591.15.1"
String curveName = ECUtil.getCurveName(identifier); // expect "ed25519", got null

I get null as curveName while I expect "ed25519".
See http://oid-info.com/get/1.3.6.1.4.1.11591.15.1

The curve is likely not properly entered into BCs curve tables.

[dghgit]

It's a little more complicated than that... while they're both EC algorithms the mathematical presentation for them is different, so while there's an overlap as one curve X25519 is specified in both forms, the regular EC curves and the Ed curves are not quite the same thing. I've added a method on PGPUtil for looking up the curve name - it will return a name in the same way as the OID is described in the draft RFC.

[dghgit]

Okay, this should now be in place. The new method is at:

bc-java/pg/src/main/java/org/bouncycastle/openpgp/PGPUtil.java

Line 130 in 269be03

public static String getCurveName(

I think it should do the trick. Now also up in https://www.bouncycastle.org/betas 171 b04 or later.

[vanitasvitae]

Apparently the patch does use some wrong curve OIDs. See #1142 for details.