Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

junit.framework.ComparisonFailure: expected:<It's 1:12:00[ ]PM GMT at Aug 17, 20...> but was:<It's 1:12:00[ ]PM GMT at Aug 17, 20...> #1530

Closed
vaukai opened this issue Nov 9, 2023 · 4 comments

Comments

@vaukai
Copy link

vaukai commented Nov 9, 2023

With Java 21 Gentoo gets a test failure:

There was 1 failure:
1) testGetEntry(org.bouncycastle.i18n.test.LocalizedMessageTest)
junit.framework.ComparisonFailure: expected:<It's 1:12:00[ ]PM GMT at Aug 17, 20...> but was:<It's 1:12:00[ ]PM GMT at Aug 17, 20...>
        at junit.framework.Assert.assertEquals(Assert.java:100)
        at junit.framework.Assert.assertEquals(Assert.java:107)
        at junit.framework.TestCase.assertEquals(TestCase.java:260)
        at org.bouncycastle.i18n.test.LocalizedMessageTest.testGetEntry(LocalizedMessageTest.java:61)

FAILURES!!!
Tests run: 276,  Failures: 1

The full build log, too long for posting here, is located at https://917070.bugs.gentoo.org/attachment.cgi?id=874350

@dghgit
Copy link
Contributor

dghgit commented Nov 10, 2023

I've pushed an update for this one as well, should now be fixed.

@vaukai
Copy link
Author

vaukai commented Nov 10, 2023

Thanks for fixing it. Now using a 811c490 snapshot with old test-data I get the following:

There were 2 failures:
1) testVectors(org.bouncycastle.pqc.crypto.test.CrystalsKyberTest)
junit.framework.AssertionFailedError: kyber512.rsp 0: secret key
        at junit.framework.Assert.fail(Assert.java:57)
        at junit.framework.Assert.assertTrue(Assert.java:22)
        at junit.framework.TestCase.assertTrue(TestCase.java:192)
        at org.bouncycastle.pqc.crypto.test.CrystalsKyberTest.testVectors(CrystalsKyberTest.java:202)
2) testVectors(org.bouncycastle.pqc.crypto.test.CrystalsDilithiumTest)
junit.framework.AssertionFailedError: PQCsignKAT_Dilithium2.rsp 0 secret key
        at junit.framework.Assert.fail(Assert.java:57)
        at junit.framework.Assert.assertTrue(Assert.java:22)
        at junit.framework.TestCase.assertTrue(TestCase.java:192)
        at org.bouncycastle.pqc.crypto.test.CrystalsDilithiumTest.testVectors(CrystalsDilithiumTest.java:141)

FAILURES!!!
Tests run: 277,  Failures: 2

@dghgit
Copy link
Contributor

dghgit commented Nov 10, 2023

Yes, you'll need the latest test data now - both those algorithm changed on the publication of the drafts for FIPS PUB 203 and FIPS PUB 204. You'll find even the Interop certificates on the IETF website have updated as well now.

@vaukai
Copy link
Author

vaukai commented Nov 10, 2023

Tested and works.

vanitasvitae pushed a commit to pgpainless/bc-java that referenced this issue Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants