Implement Argon2 S2K mechanism #1132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PreferredAEADAlgorithms was changed from 34 to 39 Key Block was added
Note: SHA3-256 and SHA3-512 values have changed
|
Ready for review :) I can squash the commits if necessary. |
vanitasvitae
force-pushed
the
crypto-refresh_tags
branch
from
0483ec9
to
a7bfbfc
Compare
|
Squashed where sensible. |
|
Thanks for the patch! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement the new Argon2 S2K mechanism for OpenPGP.
The PR further contains some updates from the crypto-refresh revision of the OpenPGP spec.
This is still pretty much work in progress, so do not yet merge!I added factory methods for different S2K methods to the S2K class.
This should make creating S2K instances more straight forward, since the S2K method is no longer derived from argument ordering.
This also enables creating S2Ks using GNU_DUMMY_S2K methods.