Fix retransmission of DTLS server flight after a retransmitted aggregated packet #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanLennox
changed the title
Even for non-handshake records. This is necessary to parse aggregated DTLS packets.
JonathanLennox
force-pushed
the
Handshake-UnitTests
branch
from
d8e7eab
to
2b54ad3
Compare
|
Note: I updated this PR to remove some files that got checked in accidentally (gradlew etc.) |
|
This PR has now been merged and will be included in the 1.77 release that we are currently preparing. We especially appreciate the extra test cases. |
pull bot
pushed a commit
to jianyuyanyu/bc-csharp
that referenced
this pull request
Nov 10, 2023
… ChangeCipherSpec - see bcgit/bc-java#1491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue described in #1489, and adds unit tests.
The records parsed here, and handed to record processing, are still a subset of the records that were parsed prior to commit 2307836, so this should be safe.