Add support for explicit entropy source in NTRUEncryptionKeyGenerationParameters #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not possible to use any other entropy source other than CrytpoServicesRegistrar#getSecureRandom(). Even worse, the provided parameters use the SecureRandom from the registrar *present at class load time* which makes it difficult to customize the SecureRandom used by NTRUEncrypt.
|
Thanks for the patch. Now merged with minor changes. Will show up in next beta (165b10). |
ok3141
pushed a commit
to ok3141/bc-java
that referenced
this pull request
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to use any other entropy source other than
CryptoServicesRegistrar#getSecureRandom().Even worse, the provided parameters use the
SecureRandomfrom the registrar present at class load time which makes it difficult to customize the entropy source used by NTRUEncrypt.Change is backward compatible, tho I'm planning on opening another PR that deprecates the existing parameters and uses another method of obtaining the standard NTRU parameters where one can specify the entropy source at generation time.