Add support for argon2 on web platform #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mwcw I think this solves the problems we'd been having with argon2 on the web. This library's focus isn't on speed anyways (and technically, neither is Argon2's), so I'd recommend merging it. |
|
Hi, I'll take a look at it tomorrow (Melb, AU) time or perhaps if I can this evening. MW |
|
Thanks! Merged will be synced in a few hours. MW |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Register64.mul, add Register64.mod and add support for argon2 on web platform.
Register64.mulhas an error on web platform whenp1is a 33-bit integer. Dartinton web platform (Javascript) will make the result an 32-bit integer, which is not the same as Dart VM. This PR fixes this, and add some tests for this problem.mod(int)opertaion on classRegister64. This method is implemented using Horner's method. Maybe we can implement it using Knuth's method for a better performance later.Argon2BytesGeneratorwhich is implemented usingRegister64, and it can run on web platform with higher memory occupation and worse performance. This PR uses a platform-aware method to determine use either Register64 impl or native int impl.