Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of fallback not existing (duplicate, not needed) #20

Closed
wants to merge 2 commits into from

Conversation

DerekRoberts
Copy link
Member

If tag_fallback isn't specified it will trigger the build. So there is no need to check if that tag exists.

Changed the way the fallback image check works. Now The command is run with all output and error sent to /dev/null. Then using the $? variable which will be 0 if found or 1 for other errors.

GitHub has a quirk. If NO packages exist for a repository it returns 403 instead of 401 not found.

Thanks @pauldaustin for the PR! GitHub Actions permissions don't allow package writing from forks, so the branch has been copied here.

@DerekRoberts DerekRoberts self-assigned this Jun 1, 2023
@DerekRoberts DerekRoberts added the bug Something isn't working label Jun 1, 2023
@DerekRoberts DerekRoberts changed the title Don't check image tag if tag_fallback isn't specified Better handling of fallback not existing Jun 1, 2023
@DerekRoberts
Copy link
Member Author

Never mind! Original PR was fixable.

@DerekRoberts DerekRoberts deleted the pauldaustin_feature/tagfallback branch June 1, 2023 19:28
@DerekRoberts DerekRoberts changed the title Better handling of fallback not existing Better handling of fallback not existing (not needed) Jun 1, 2023
@DerekRoberts DerekRoberts changed the title Better handling of fallback not existing (not needed) Better handling of fallback not existing (duplicate, not needed) Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants