remove irrelevant info and broken links #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obrien-j
reviewed
Jan 18, 2019
| @@ -25,10 +25,6 @@ There is a [healthy debate](http://www.dwheeler.com/secure-programs/Secure-Progr | |||
| - **Review the code** | |||
|
|
|||
| Sounds obvious but this step has been skipped by every developer in the world at least once. The simple action of having a second set of eyes on the code can avoid many pitfalls before it's too late. | |||
There was a problem hiding this comment.
Hey @patricksimonian , I've been lurking on this repo for a while. Great stuff by the way.
Just a thought on this section. You may want to discuss the various options available in most git systems to allow for 'protected branches & mandatory code reviews'...
There was a problem hiding this comment.
That's a really great point! Do you have any preferred resources on that that you have found especially helpful or would pointing towards the github docs suffice?
|
I haven't found a resource that I'm overly thrilled with, so yeah, point to
docs of your current repo provider in the interim. We're looking to
document more of our internal practices at CDS (https://digital.canada.ca)
so I'll keep you posted if we get something that's worth a reference. ;)
…On Fri, 18 Jan 2019 at 12:02, Patrick Simonian ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In BC-Open-Source-Development-Employee-Guide/Security.md
<#34 (comment)>
:
> @@ -25,10 +25,6 @@ There is a [healthy debate](http://www.dwheeler.com/secure-programs/Secure-Progr
- **Review the code**
Sounds obvious but this step has been skipped by every developer in the world at least once. The simple action of having a second set of eyes on the code can avoid many pitfalls before it's too late.
That's a really great point! Do you have any preferred resources on that
that you have found especially helpful or would pointing towards the github
docs suffice?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHGyOWxH4xEA-XbHR4RluUIxFTAH6cItks5vEf4mgaJpZM4aGnJG>
.
|
|
I made #35 to keep track of this. Do any of you mind taking a look through and adding some comments or wishlist items for that issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.