Inconsistent mimetype/extension detection

[jujaga]

OCWA Issue

User Story

As a researcher,

I want to be able to upload any type of file and have the filetype be parsed and handled correctly

so that the application can properly run validation tests on the files and yield useful output.

Test Case

ENV

• DEV
• TEST
• PROD

TESTCASE

• Login and create new request
• Click Add files
• Drag and drop the LICENSE file from the OCWA repository as a file to submit

EXPECTED

• The file should successfully submit, with a filetype recognized as text/plain (or similar)
• Subsequent screens should yield validation rule results that make sense for the uploaded file

ACTUAL

• The file appears to successfully submit, but no filetype is registered with it.
• Subsequent validation screens do not yield proper results.

ERROR

From Validation API

2019-02-15 19:04:30,436 - DEBUG - Error 'filetype'
Process Process-54:2:
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/multiprocessing/process.py", line 297, in _bootstrap
    self.run()
  File "/usr/local/lib/python3.7/multiprocessing/process.py", line 99, in run
    self._target(*self._args, **self._kwargs)
  File "/app/validator/validator.py", line 37, in validate
    result, message = read_file_and_evaluate(source, resultObj)
  File "/app/validator/validator.py", line 51, in read_file_and_evaluate
    result['file_id'], '${file.content}' in source)
  File "/app/validator/validator.py", line 171, in read_file
    index = file[ftIndex].find('/')
KeyError: 'filetype'

Notes

• This issue only occurs more frequently on Windows, but can be replicated on macOS as well.
• Markdown files tend to also exhibit this issue, but not in all cases. Haven't been able to isolate root cause.
• So far we've discovered that we simply do not have the ${file.filetype} attribute defined, which is causing an error on the validationApi.