Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #113

Merged
merged 46 commits into from
Mar 20, 2019
Merged

Develop #113

merged 46 commits into from
Mar 20, 2019

Conversation

jujaga
Copy link
Member

@jujaga jujaga commented Mar 20, 2019

Description

This PR brings in most of the changes done in Sprint 51 into master.
Issues: #54, #84, #97, #99, #111
PRs: #88, #106, #109, #110, #112

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change with enhancements to documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

BrandonSharratt and others added 30 commits March 7, 2019 15:57
@BrandonSharratt
working commit
0ccfe1a
@jujaga
Force the docker bash scripts to return non-zero if there is a failure
2f36570 
Add trap to return useful output upon failure

Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@Jonesy
Fix search bugs, request state icon colours and add new loading desig…
2095cb1 
…n pattern for requests list page.
@Jonesy
Add lint npm command.
5688ed5
@jujaga
Fix casing issue for loading component
8bcdd77 
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@Jonesy
Prevent a request with unconfirmed file validation to be submitted an…
316e76f 
…d require the user to check first.
@Jonesy
Remove console's and uncomment essential submit action.
da959b6
@BrandonSharratt
working commit
8eabb12
@BrandonSharratt
first pass at queue validation, with graceful termination
9b7977b
@BrandonSharratt
few bug fixes and tweaks
7feb180
@BrandonSharratt
missing space
725cb7c
@BrandonSharratt
merge
a1363fc
@BrandonSharratt
forgot to update terraform
f415ee3
@BrandonSharratt
missed init validator in validate policy route
89a268a
@BrandonSharratt
missing init py
f72d844
@BrandonSharratt
forgot to del old pids from processes array
fc7fe95
@BrandonSharratt
PR changes requested
9ac5153
@BrandonSharratt
reduce sleepy nap time
9ca9c6f
@BrandonSharratt
use index instead of i
e3e92ab
@BrandonSharratt
use index instead of i
2d914b2
@BrandonSharratt
pep8 comments
ec1e604
@BrandonSharratt
added log statement for when a file is too large
9d6ece9
@jujaga
Merge pull request #106 from bcgov/feature/working-limit
1d44ef7 
Feature/working limit
@BrandonSharratt
sig int handler isn't actually allowed to abort threads the sig int p…
75b02ef 
…ropogation does it so removing the join/abort
@BrandonSharratt
remove erroneous print
83e92bf
@jujaga
Merge branch 'feature/working-limit' into develop
2194951 
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@BrandonSharratt
tweaked message and file status checking, now gives the message it di…
e0d3d87 
…d before if a file is blocked, or if none are blocked but one is pending it will say that instead
@Jonesy
Revert submit button behavior and add message text to file status p…
cea90a1 
…opover.
@BrandonSharratt
quoted working limit
e7a25a8
@Jonesy
Replace regex escape with lodash version, add it to OC dashboard as w…
dcfdbed 
…ell.
jujaga and others added 16 commits March 13, 2019 12:12
@jujaga
Merge pull request #109 from bcgov/hotfix/issue-97
492e0e8 
Minor UI Tweaks (Issue 97)
@Jonesy
Add the ability to set a dynamic title based on the component/route y…
5165f07 
…ou are viewing.
@Jonesy
Add remaining titles to the request tabs and OC section.
fe5106b
@jujaga
Merge pull request #110 from bcgov/feature/issue-84
2ffc29e 
Add dynamic document.titles
@jujaga
Synchronize package-lock.json package name with package.json
50682cb 
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga
Initial groovy package shifting
aade9a4 
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga
Refactor random keyword request generator
4afa42d 
Begin Constant string refactor

Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga
Change design to use Step class inheritance for "session" variables
d92b857 
Begin login step separation

Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga
Split download ui test from adjudicate_request
9e15912 
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga
Migrate requester constants
2714ad7 
Simplify TestObjects for login
Refactor and remove some Object Repository objects

Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga
Refactor requester_uploads_files to handle multiple files more elegantly
108ed24 
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga
Simplify and cleanup Object Repository
7bf1d6a 
Partially extract out remaining login/logout code

Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga
Remove unnecessary delays
d35e909 
Streamline duplicate state code

Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga
Create default timeout constant - remove magic number
58035ab 
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga
Fix minor swapped feature file issue
292d4b5 
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@pripley123
Merge pull request #112 from bcgov/integration/refactor
521293a 
Integration/refactor
@jujaga jujaga added this to the Sprint 51 milestone Mar 20, 2019
@BrandonSharratt BrandonSharratt merged commit b31cc3b into master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonSharratt BrandonSharratt Awaiting requested review from BrandonSharratt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 51
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jujaga @BrandonSharratt @Jonesy @pripley123