Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1851 Submit Button Spacing #2500

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Jul 4, 2024

🎯 Summary

PIMS-1851

Changes

  • Small amount of padding added under Add_____ pages.

Tried to do this in the base layout at first, but there is some weird interaction with how the main component uses 100vh. This was simpler, but will have to be done for any future pages like this.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

github-actions bot commented Jul 4, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2500. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all submit buttons have padding

…extend. Also removed overflow on datatable to remove very ugly extra scrollbars in Chrome.
@GrahamS-Quartech
Copy link
Collaborator

I made some changes to this so that you don't need to add padding to every page where this occurs. It should behave more consistently between browsers too. Also noticed that Chrome adds these extra unnecessary scrollbars to the DataTable, so I removed the overflow prop to make them go away.

@TaylorFries TaylorFries merged commit f11ca1a into main Jul 5, 2024
5 checks passed
@TaylorFries TaylorFries deleted the PIMS-1851-Submit-Button-Spacing branch July 5, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants