Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lease Last Updated By | PSP-6933 #3512

Merged
merged 10 commits into from
Oct 26, 2023
Merged

Conversation

FuriousLlama
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #3512 (6fda27d) into dev (274cb03) will decrease coverage by 0.81%.
The diff coverage is 3.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3512      +/-   ##
==========================================
- Coverage   69.77%   68.96%   -0.81%     
==========================================
  Files        1369     1370       +1     
  Lines       33121    33518     +397     
  Branches     6210     6217       +7     
==========================================
+ Hits        23111    23117       +6     
- Misses       9760    10151     +391     
  Partials      250      250              
Flag Coverage Δ
unittests 68.96% <3.43%> (-0.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...asePages/improvements/AddImprovementsContainer.tsx 97.36% <100.00%> (+0.07%) ⬆️
.../LeasePages/improvements/ImprovementsContainer.tsx 58.33% <100.00%> (ø)
...tail/LeasePages/tenant/AddLeaseTenantContainer.tsx 87.32% <100.00%> (+0.18%) ⬆️
...eases/detail/LeasePages/tenant/TenantContainer.tsx 10.00% <ø> (ø)
...end/src/features/mapSideBar/lease/ViewSelector.tsx 10.00% <ø> (ø)
...c/features/mapSideBar/lease/common/LeaseHeader.tsx 82.35% <100.00%> (ø)
...res/mapSideBar/lease/detail/LeaseTabsContainer.tsx 4.34% <ø> (ø)
...detail/LeasePages/insurance/InsuranceContainer.tsx 3.03% <0.00%> (-0.10%) ⬇️
...etail/LeasePages/payment/TermPaymentsContainer.tsx 78.46% <75.00%> (-0.91%) ⬇️
...easePages/payment/hooks/useDeleteTermsPayments.tsx 92.15% <50.00%> (-1.73%) ⬇️
... and 9 more

@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@devinleighsmith
Copy link
Collaborator

updating tenants doesn't seem to trigger the update info to refresh.

@devinleighsmith
Copy link
Collaborator

Tenants, Improvements, Insurance, Deposit, Payments tabs all do not appear to trigger the updateInfo request.

Copy link
Collaborator

@devinleighsmith devinleighsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

large number of sub-entities not working as intended.

@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@FuriousLlama FuriousLlama merged commit 37fc76f into bcgov:dev Oct 26, 2023
8 of 9 checks passed
@FuriousLlama FuriousLlama deleted the features/psp-6933 branch October 30, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants