Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agreements statuscompletition | psp-7079 #3590

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

devinleighsmith
Copy link
Collaborator

@devinleighsmith devinleighsmith commented Nov 10, 2023

Check for draft agreements and compensations when completing a file.

@devinleighsmith devinleighsmith added the enhancement New feature or request label Nov 10, 2023
@devinleighsmith devinleighsmith self-assigned this Nov 10, 2023
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #3590 (4233024) into dev (06c1bd1) will increase coverage by 0.01%.
The diff coverage is 91.30%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3590      +/-   ##
==========================================
+ Coverage   69.64%   69.66%   +0.01%     
==========================================
  Files        1372     1372              
  Lines       33995    34012      +17     
  Branches     6361     6364       +3     
==========================================
+ Hits        23676    23694      +18     
  Misses      10064    10064              
+ Partials      255      254       -1     
Flag Coverage Δ
unittests 69.66% <91.30%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rce/backend/api/Services/AcquisitionFileService.cs 73.70% <100.00%> (+0.87%) ⬆️
.../fileDetails/update/UpdateAcquisitionContainer.tsx 96.29% <100.00%> (+0.64%) ⬆️
source/frontend/src/hooks/useApiUserOverride.ts 92.85% <100.00%> (+0.17%) ⬆️
source/frontend/src/utils/axiosUtils.ts 81.39% <60.00%> (-3.61%) ⬇️

@FuriousLlama FuriousLlama changed the title Psp 7079 Agreements statuscompletition | psp-7079 Nov 17, 2023
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit ccf14e7 into bcgov:dev Nov 20, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants