Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-4389, PSP-4409 Tech debt fixes #3612

Merged
merged 4 commits into from
Nov 23, 2023
Merged

PSP-4389, PSP-4409 Tech debt fixes #3612

merged 4 commits into from
Nov 23, 2023

Conversation

asanchezr
Copy link
Collaborator

No description provided.

@asanchezr asanchezr added the tech-debt Removing technical debt label Nov 23, 2023
@asanchezr asanchezr self-assigned this Nov 23, 2023
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #3612 (a3d43fb) into dev (333aa17) will increase coverage by 5.09%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3612      +/-   ##
==========================================
+ Coverage   69.68%   74.77%   +5.09%     
==========================================
  Files        1372      899     -473     
  Lines       34020    18738   -15282     
  Branches     6366     5328    -1038     
==========================================
- Hits        23707    14012    -9695     
+ Misses      10059     4726    -5333     
+ Partials      254        0     -254     
Flag Coverage Δ
unittests 74.77% <100.00%> (+5.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
source/frontend/src/components/Table/Table.tsx 80.07% <100.00%> (ø)
...rce/frontend/src/components/common/OverflowTip.tsx 100.00% <100.00%> (ø)
.../frontend/src/components/common/TooltipWrapper.tsx 100.00% <100.00%> (ø)
...ntend/src/components/common/buttons/PlusButton.tsx 100.00% <ø> (ø)
...tend/src/components/common/buttons/ResetButton.tsx 100.00% <ø> (ø)
...end/src/components/common/buttons/SearchButton.tsx 100.00% <ø> (ø)
...tend/src/components/common/form/AsyncTypeahead.tsx 88.88% <ø> (ø)
...ontend/src/components/common/form/ContactInput.tsx 82.75% <ø> (ø)
...ents/common/form/ContactInput/ContactInputView.tsx 100.00% <ø> (ø)
...urce/frontend/src/components/common/form/Input.tsx 80.00% <ø> (ø)
... and 26 more

... and 473 files with indirect coverage changes

Copy link
Contributor

✅ No secrets were detected in the code.

@asanchezr asanchezr merged commit 265fa01 into bcgov:dev Nov 23, 2023
9 checks passed
@asanchezr asanchezr deleted the tech-debt branch November 23, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Removing technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants