PSP-6948 : Create a disposition file #3631
Conversation
eddherrera
commented
Dec 1, 2023
eddherrera
commented
# Conflicts: # source/backend/entities/Partials/DispositionStatusTypeCode.cs # source/backend/tests/core/Entities/DispositionFileHelper.cs
|
ui issues:
Please discuss these visual differences with Ana. Personally, I think swapping the x icon out with a trash can should have been handled by another story, as that component is shared by multiple files. Also the text +Add contact... is strictly worse than +Add Team Member... |
|
This error means that you need to make these fields nullable in the yup schema: |
|
adding a property to a disposition file doesn't appear to work. Clicking the drop marker icon on the map doesn't seem to add anything to the list. |
| [HasPermission(Permissions.DispositionAdd)] | ||
| [Produces("application/json")] | ||
| [ProducesResponseType(typeof(DispositionFileModel), 200)] | ||
| [SwaggerOperation(Tags = new[] { "dispositionfile" })] |
There was a problem hiding this comment.
please add:
[TypeFilter(typeof(NullJsonResultFilter))]
to ensure that null values are handled appropriately.
| } | ||
| else | ||
| { | ||
| if (overrideCodes.Contains(UserOverrideCode.DisposingPropertyNotInventoried)) |
There was a problem hiding this comment.
some potential to extract this repeated code into a shared method.
(153 - 161
| try | ||
| { | ||
| var foundProperty = _propertyRepository.GetByPid(pid); | ||
| dispProperty.PropertyId = foundProperty.Internal_Id; |
There was a problem hiding this comment.
this is missing the
UpdateLocation(acquisitionProperty.Property, ref foundProperty, userOverrideCodes);
method that is in the acquisitionfileservice.
What that'll mean is that when a pre-existing property is added to a disposition file it will not be possible to update it's location on the map. Perhaps this is ok?
| @@ -15,6 +16,11 @@ namespace Pims.Dal.Repositories | |||
| /// </summary> | |||
| public class DispositionFileRepository : BaseRepository<PimsDispositionFile>, IDispositionFileRepository | |||
| { | |||
| private const string FILENUMBERPREFIX = "D"; | |||
There was a problem hiding this comment.
Please remove this. The D in front of the file number is for display only, we don't want the D in the database.
| using var scope = Logger.QueryScope(); | ||
| disposition.ThrowIfNull(nameof(disposition)); | ||
|
|
||
| disposition.FileNumber = GeneratetDispositionFileNumber(); |
| dispositionInitialValues: DispositionFormModel; | ||
| loading: boolean; | ||
| displayFormInvalid: boolean; | ||
| // onSubmit: (dispositionFile: Api_DispositionFile) => Promise<Api_DispositionFile | undefined>; |
There was a problem hiding this comment.
remove if not needed.
# Conflicts: # source/backend/api/Areas/Disposition/Controllers/DispositionFileController.cs # source/backend/api/Services/IDispositionFileService.cs # source/backend/dal/Repositories/DispositionFileRepository.cs # source/frontend/src/constants/API.ts # source/frontend/src/hooks/pims-api/useApiDispositionFile.ts # source/frontend/src/hooks/repositories/useDispositionProvider.ts
|
Fixed issues, pending to review with Ana |
# Conflicts: # source/backend/api/Areas/Disposition/Controllers/DispositionFileController.cs # source/backend/apimodels/Models/Concepts/DispositionFile/DispositionFileMap.cs # source/backend/dal/Exceptions/OverrideExceptions.cs
