Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psp 7306 - update term modal ui #3671

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Conversation

devinleighsmith
Copy link
Collaborator

No description provided.

@devinleighsmith devinleighsmith added the enhancement New feature or request label Dec 18, 2023
@devinleighsmith devinleighsmith self-assigned this Dec 18, 2023
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (08c05b6) 71.34% compared to head (2812d4a) 74.18%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3671      +/-   ##
==========================================
+ Coverage   71.34%   74.18%   +2.84%     
==========================================
  Files        1427      939     -488     
  Lines       36438    20018   -16420     
  Branches     6815     5731    -1084     
==========================================
- Hits        25995    14850   -11145     
+ Misses      10175     5168    -5007     
+ Partials      268        0     -268     
Flag Coverage Δ
unittests 74.18% <83.33%> (+2.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../detail/LeasePages/payment/modal/term/TermForm.tsx 100.00% <ø> (ø)
...etail/LeasePages/payment/TermPaymentsContainer.tsx 82.43% <90.90%> (+3.97%) ⬆️
...d/src/features/mapSideBar/lease/LeaseContainer.tsx 7.54% <0.00%> (ø)

... and 487 files with indirect coverage changes

@devinleighsmith devinleighsmith marked this pull request as ready for review December 21, 2023 20:58
Copy link
Contributor

github-actions bot commented Jan 2, 2024

✅ No secrets were detected in the code.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

✅ No secrets were detected in the code.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit bd2dce3 into bcgov:dev Jan 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants