Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-7819 FT: Disposition File - Grey marker appears as Other Interest when the Advanced Filters for IS_DISPOSED is not selected #3793

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

asanchezr
Copy link
Collaborator

No description provided.

@asanchezr asanchezr added the bug Something isn't working label Feb 14, 2024
@asanchezr asanchezr self-assigned this Feb 14, 2024
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d19fa00) 75.61% compared to head (c1588e0) 74.05%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3793      +/-   ##
==========================================
- Coverage   75.61%   74.05%   -1.56%     
==========================================
  Files        1450      956     -494     
  Lines       38402    21004   -17398     
  Branches     7276     6124    -1152     
==========================================
- Hits        29038    15555   -13483     
+ Misses       9070     5449    -3621     
+ Partials      294        0     -294     
Flag Coverage Δ
unittests 74.05% <84.21%> (-1.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tend/src/models/layers/pimsPropertyLocationView.ts 100.00% <ø> (ø)
...ents/common/mapFSM/machineDefinition/mapMachine.ts 13.20% <0.00%> (-0.26%) ⬇️
...ontend/src/components/maps/leaflet/Layers/util.tsx 79.62% <90.90%> (+6.98%) ⬆️
...c/components/maps/leaflet/Markers/SingleMarker.tsx 73.07% <85.71%> (+0.34%) ⬆️

... and 494 files with indirect coverage changes

@asanchezr asanchezr merged commit 8fe93eb into bcgov:dev Feb 15, 2024
9 checks passed
@asanchezr asanchezr deleted the psp-7819-grey-marker-bug branch February 15, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants