Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-7676 | Updated the calculation of totals for property activity invoices #3812

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

FuriousLlama
Copy link
Collaborator

No description provided.

@FuriousLlama FuriousLlama added the enhancement New feature or request label Feb 22, 2024
@FuriousLlama FuriousLlama self-assigned this Feb 22, 2024
Copy link
Contributor

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

✅ No secrets were detected in the code.

@devinleighsmith
Copy link
Collaborator

Oh, interesting, I was under the impression we weren't using those fields. Good catch.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 75.42%. Comparing base (52de8b5) to head (455c24e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3812      +/-   ##
==========================================
- Coverage   75.43%   75.42%   -0.02%     
==========================================
  Files        1415     1415              
  Lines       38455    38452       -3     
  Branches     7906     7906              
==========================================
- Hits        29009    29001       -8     
- Misses       9152     9157       +5     
  Partials      294      294              
Flag Coverage Δ
unittests 75.42% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ls/Models/Concepts/Property/PropertyActivityMap.cs 100.00% <ø> (ø)
.../propertyDetailsManagement/activity/edit/models.ts 0.00% <ø> (ø)
...ent/activity/detail/PropertyActivityDetailView.tsx 5.26% <0.00%> (-1.64%) ⬇️

@FuriousLlama FuriousLlama merged commit 976b5e8 into bcgov:dev Feb 22, 2024
9 checks passed
@FuriousLlama FuriousLlama deleted the features/psp-7676 branch May 23, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants