This repository has been archived by the owner on Nov 25, 2020. It is now read-only.
Remove nonce leading zero #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
WadeBarnes
approved these changes
Mar 23, 2020
|
Fine to leave it like this, but probably would have been better to use the anoncreds nonce generator. At least I hope so - that's what ACA-Py is doing. |
|
There are 2 layers of code between Orgbook and anoncreds (von-x and von-anchor) and we're already using a patched version of von-anchor to work around another issue. If OrgBook was going to be long lived I agree on doing a different fix but for now trying to patch all 3 layers of code seems overkill. |
|
Got it. Good call! :-) |
|
Fixes #874 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.