Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v18.18.2 and pipeline modernization #10

Merged
2 commits merged into from
Oct 19, 2023
Merged

Bump to v18.18.2 and pipeline modernization #10

2 commits merged into from
Oct 19, 2023

Conversation

jujaga
Copy link
Member

@jujaga jujaga commented Oct 19, 2023

Description

This PR updates the github actions pipeline to a more versatile template, adds npm cache permission fixes, and bumps Node to v18.18.2.

SHOWCASE-3189

Types of changes

New feature (non-breaking change which adds functionality)

Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

The build-push-container action is grafted from our other projects and
works as a one-stop shop solution for publishing docker images to both
ghcr.io and docker.io if credentials are present.

Signed-off-by: Jeremy Ho <jujaga@gmail.com>
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga jujaga added the enhancement New feature or request label Oct 19, 2023
@jujaga jujaga self-assigned this Oct 19, 2023
@jujaga jujaga requested a review from TimCsaky as a code owner October 19, 2023 00:03
@ghost ghost merged commit 7c369b0 into master Oct 19, 2023
@ghost ghost deleted the chore/bump-perms branch October 19, 2023 00:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants