Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test on beta catalogue API #283

Merged
merged 36 commits into from
Oct 27, 2021
Merged

test on beta catalogue API #283

merged 36 commits into from
Oct 27, 2021

Conversation

ateucher
Copy link
Collaborator

WIP. Changes to fix #282

@ateucher
Copy link
Collaborator Author

ateucher commented Sep 14, 2021

To test this, you must set:

options("bcdata.catalogue_api_url" = "https://beta-catalogue.data.gov.bc.ca/api/3/")
options("bcdata.catalogue_gui_url" = "https://beta-catalogue.data.gov.bc.ca/")

This is currently set in tests/testhat/setup.R - we will need to comment that line out when this goes to production.

@ateucher
Copy link
Collaborator Author

@boshek we could consider using the new field bcdc_type in the resource tibble:

    type = safe_map_chr(x, "bcdc_type"),

See here.

It lists each resource as geographic, tabular, application, or webservice

@ateucher
Copy link
Collaborator Author

Also resource.resource_type and resource.resource_access_method

@ateucher ateucher mentioned this pull request Oct 19, 2021
@ateucher ateucher mentioned this pull request Oct 19, 2021
19 tasks
@ateucher
Copy link
Collaborator Author

/document

@ateucher
Copy link
Collaborator Author

/precompile

@boshek
Copy link
Collaborator

boshek commented Oct 19, 2021

/precompile

@ateucher ateucher marked this pull request as ready for review October 26, 2021 20:24
@ateucher ateucher requested a review from boshek October 26, 2021 20:26
Copy link
Collaborator

@boshek boshek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on this! One small thing and then an idea: Is there any value in making the service_documentation.md a vignette? It could make it more discoverable.

R/bcdc-web-services.R Show resolved Hide resolved
@ateucher ateucher merged commit 0db940a into master Oct 27, 2021
@ateucher ateucher deleted the catalogue-api-changes branch October 26, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for catalogue migration
2 participants