Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses #42 and #63 -- adds pkgdown site and reorgs readme content #125

Merged
merged 33 commits into from
Jun 4, 2023
Merged

Addresses #42 and #63 -- adds pkgdown site and reorgs readme content #125

merged 33 commits into from
Jun 4, 2023

Conversation

stephhazlitt
Copy link
Member

@stephhazlitt stephhazlitt commented Jun 3, 2023 •
edited
Loading

Aiming for "good enough" and definitely better than no pkgdown site 🤞

@stephhazlitt
Copy link
Member Author

There are probably a few more nice things from @ateucher's PR #44 that could be ported over (like arranging the fxns in the ref list maybe?).

@boshek
Copy link
Collaborator

boshek commented Jun 3, 2023

There are probably a few more nice things from @ateucher's PR #44 that could be ported over (like arranging the fxns in the ref list maybe?).

Probably good in a follow up. I say ship it!

@stephhazlitt
Copy link
Member Author

stephhazlitt commented Jun 3, 2023 •
edited
Loading

Once approved, does adding a pkgdown site and re-org of doc content warrant a NEWS.md entry or no? I think maybe no 🤷‍♀️ .

ateucher
ateucher approved these changes Jun 3, 2023
View reviewed changes
vignettes/add_points.Rmd.orig Outdated Show resolved Hide resolved
vignettes/bcmaps.Rmd.orig Outdated Show resolved Hide resolved
vignettes/bcmaps.Rmd.orig Outdated Show resolved Hide resolved
vignettes/bcmaps.Rmd.orig Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
_pkgdown.yml Show resolved Hide resolved
@ateucher
Copy link
Collaborator

ateucher commented Jun 3, 2023

I think adding a news entry is good, it will help people find it

stephhazlitt and others added 7 commits June 3, 2023 15:58
@stephhazlitt @ateucher
Update vignettes/add_points.Rmd.orig
bb7adba 
Co-authored-by: Andy Teucher <andy.teucher@gov.bc.ca>
@stephhazlitt @ateucher
Update vignettes/bcmaps.Rmd.orig
28e0af7 
Co-authored-by: Andy Teucher <andy.teucher@gov.bc.ca>
@stephhazlitt @ateucher
Update vignettes/bcmaps.Rmd.orig
bf0f07f 
Co-authored-by: Andy Teucher <andy.teucher@gov.bc.ca>
@stephhazlitt @ateucher
Update README.Rmd
b6e52e2 
Co-authored-by: Andy Teucher <andy.teucher@gov.bc.ca>
@stephhazlitt @ateucher
add dev auto mode
9eeba09 
Co-authored-by: Andy Teucher <andy.teucher@gmail.com>
@stephhazlitt
render text update
8d1ac0c
@stephhazlitt
implement #124
8936485
ateucher
ateucher approved these changes Jun 4, 2023
View reviewed changes
Copy link
Collaborator

@ateucher ateucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, good to merge!

vignettes/bcmaps.Rmd.orig Outdated Show resolved Hide resolved
vignettes/bcmaps.Rmd.orig Show resolved Hide resolved
stephhazlitt and others added 3 commits June 4, 2023 08:29
@stephhazlitt @ateucher
Update vignettes/bcmaps.Rmd.orig
d199416 
Co-authored-by: Andy Teucher <andy.teucher@gov.bc.ca>
@stephhazlitt @ateucher
use reset = FALSE
c2c48a0 
Co-authored-by: Andy Teucher <andy.teucher@gmail.com>
@stephhazlitt
precompile
6d4533f
@stephhazlitt stephhazlitt merged commit 954ebee into main Jun 4, 2023
7 checks passed
@stephhazlitt stephhazlitt deleted the issue-42-63 branch June 4, 2023 16:07
This was referenced Jun 5, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ateucher ateucher ateucher approved these changes

@boshek boshek boshek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephhazlitt @boshek @ateucher