13565 Implement Missing Information alert and conversion todo item #407
Conversation
severinbeauvais
force-pushed
the
13565
branch
from
652f5ea
to
081d301
Compare
| p { | ||
| font-size: $px-15; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
Looks like this:
There was a problem hiding this comment.
Nature of business isn't actually something we check for in the missing business info check. Is the reference to nature of business still ok?
There was a problem hiding this comment.
Alert looks nice at the top and closed by default btw.
There was a problem hiding this comment.
If the alert needs to be changed, it will need another ticket.
| p, li { | ||
| color: $gray7; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
Looks like this:
| </template> | ||
| <template v-if="isNotInCompliance"> | ||
| You cannot view or change business information while the business is not in compliance. | ||
| <v-icon color="orange darken-2" size="24px" class="pr-2" v-on="on">mdi-alert</v-icon> | ||
| </template> |
There was a problem hiding this comment.
"Not in compliance" is now an alert, so this tooltip is removed for this case (per Tracey).
This tooltip remains for "pending dissolution", except it's not implemented yet (is always false).
severinbeauvais
force-pushed
the
13565
branch
from
081d301
to
0c1c062
Compare
| <!-- FUTURE: move these to a new Alerts component and inside one expansion panel --> | ||
| <MissingInformation v-if="isMissingInformationAlert"/> | ||
| <NotInGoodStanding v-if="isNotInGoodStandingAlert"/> | ||
| </section> |
There was a problem hiding this comment.
Looks like this:
| StaffNotation, | ||
| CoaWarningDialog | ||
| TodoList | ||
| }, |
There was a problem hiding this comment.
^^ components are now sorted (no functional difference but easier to verify visually)
| warnings: [{ warningType: 'COMPLIANCE' }, { warningType: 'COMPLIANCE' }], | ||
| buttonExists: true, | ||
| tooltip: 'not in compliance' | ||
| }, |
There was a problem hiding this comment.
Tooltip was removed for not in compliance.
| @@ -256,7 +248,6 @@ describe('EntityInfo - company info button and tooltip', () => { | |||
|
|
|||
| store.state.entityType = _.entityType | |||
| store.state.goodStanding = _.goodStanding || false | |||
| store.state.businessWarnings = _.warnings || [] | |||
There was a problem hiding this comment.
Warnings were deleted from test array above.
Codecov Report
@@ Coverage Diff @@
## main #407 +/- ##
==========================================
+ Coverage 82.88% 84.83% +1.94%
==========================================
Files 109 107 -2
Lines 2104 2143 +39
Branches 659 489 -170
==========================================
+ Hits 1744 1818 +74
+ Misses 360 325 -35
|
…ltip (now handled by alert, per Tracey) - moved alerts from Todo List to Dashboard component - moved View/Hide Details button beside title for all states/types - added Todo List action button for conversion task for staff only - added Todo List content for conversion task - implemented loadConversionTodo() - added conversion code to doFileNow() - refactored ActionRequired component to match UI designs - added NotInGoodStanding component - added ConversionDetails component - included missing info warning as a blocker - renamed some getters - added Alerts section to dashboard - misc cleanup - added unit tests - app version = 5.7.7
severinbeauvais
force-pushed
the
13565
branch
from
0c1c062
to
c4ccd8f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| <v-btn v-if="showDetailsBtnRed(item)" class="expand-btn ml-1" text color="error" :ripple=false> | ||
| <v-icon>mdi-information-outline</v-icon> | ||
| <span>{{ (panel === index) ? "Hide Details" : "View Details" }}</span> | ||
| </v-btn> |
There was a problem hiding this comment.
Looks like this:
Instead of this:
Expanded details:
This change was OKed by Yui.
|
|
||
| <!-- draft with pay error --> | ||
| <div v-else-if="isStatusDraft(item) && isPayError(item)" class="todo-subtitle"> | ||
| <span>PAYMENT INCOMPLETE</span> |
There was a problem hiding this comment.
I moved this up as it supersedes all other possible draft statuses.
| <div v-else-if="isStatusDraft(item) && isTypeAlteration(item) && !item.goodStanding" | ||
| class="todo-list-detail body-2" |
| > | ||
| <v-icon class="pr-1" color="primary" size="18px">mdi-delete-forever</v-icon> | ||
| <v-list-item-title>Delete Draft</v-list-item-title> | ||
| <v-list-item-title>Delete draft</v-list-item-title> |
There was a problem hiding this comment.
This is in line with "Delete changes to company information" (line 259).
| id="btn-delete-draft-alt" | ||
| @click="confirmDeleteDraft(item)" | ||
| id="btn-draft-delete" | ||
| @click.stop="confirmDeleteDraft(item)" |
There was a problem hiding this comment.
Bugfix: this stops the action from bubbling up to parent elements (which eventually causes this panel to open or close, unexpectedly).
| @@ -493,7 +476,7 @@ | |||
| </v-expansion-panels> | |||
|
|
|||
| <!-- No Results Message --> | |||
| <v-card class="no-results" flat v-if="!showTodoPanel && !isActionRequired"> | |||
There was a problem hiding this comment.
This panel may still display even if an action is required (which is now a "missing information" alert).
| if (this.isStatusError(item) && (this.inProcessFiling !== item.filingId)) return true | ||
| if (this.isStatusPaid(item) && (this.inProcessFiling !== item.filingId)) return true | ||
| return false | ||
| } |
There was a problem hiding this comment.
These are to simplify the template.
| @@ -680,11 +680,8 @@ export default class TodoList extends Vue { | |||
| } | |||
| } | |||
|
|
|||
| // Add todo items count +1 when SP/GP with compliance warning | |||
| const todoLength = this.isActionRequired ? this.todoItems.length + 1 : this.todoItems.length | |||
There was a problem hiding this comment.
This was because the previous panel counted as a Todo item. Now that panel (alert) is in its own section above the Todo section.
| let subtitle: string = null | ||
| if (task.enabled && !this.isBComp) { | ||
| subtitle = '(including Address and/or Director Change)' | ||
| } |
There was a problem hiding this comment.
Easier-to-understand logic!
severinbeauvais
requested review from
lewischenstudio,
lambert-alex and
argush3
|
A little late to this review but looks good. Just the one thing I brought up. Nice to finally see this in action. Being able to actually see what's missing is a nice touch too! |
Issue #: bcgov/entity#13565
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).