Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parallel and incremental builds #7

Merged
merged 16 commits into from
Aug 21, 2019
Merged

Support parallel and incremental builds #7

merged 16 commits into from
Aug 21, 2019

Conversation

matthieu-foucault
Copy link
Contributor

The oc_build function now takes care of creating/updating the BuildConfig, and allows the build configs to output to an ImageStream tag using GIT_BRANCH_NORM instead of SHA1

@wenzowski wenzowski mentioned this pull request Aug 20, 2019
Open
wenzowski
wenzowski approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@wenzowski wenzowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add check for jq and tests in subsequent PR

wenzowski
wenzowski approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@wenzowski wenzowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed by pair

@wenzowski wenzowski merged commit cc30810 into master Aug 21, 2019
@wenzowski wenzowski deleted the feature/output-to-branch-tag branch August 21, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzowski wenzowski wenzowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthieu-foucault @wenzowski