Skip to content

Commit

Permalink
Fix SIGTERM propagation and update to Node 20 LTS
Browse files Browse the repository at this point in the history
Also update Github Actions pipelines to handle Node 20

Signed-off-by: Jeremy Ho <jujaga@gmail.com>
  • Loading branch information
jujaga committed Nov 20, 2023
1 parent 8e4f854 commit 374cdf6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/unit-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ jobs:
fail-fast: true
matrix:
node-version:
- '14.x'
- '16.x'
- '18.x'
- '20.x'
steps:
- name: Checkout Repository
uses: actions/checkout@v3
Expand Down Expand Up @@ -53,14 +53,14 @@ jobs:
env:
CI: true
- name: Save Coverage Results
if: matrix.node-version == '18.x'
if: matrix.node-version == '20.x'
uses: actions/upload-artifact@v3
with:
name: coverage-app
path: ${{ github.workspace }}/app/coverage
retention-days: 1
- name: Monitor Coverage
if: "matrix.node-version == '18.x' && ! github.event.pull_request.head.repo.fork"
if: "matrix.node-version == '20.x' && ! github.event.pull_request.head.repo.fork"
uses: slavcodev/coverage-monitor-action@v1
with:
comment_mode: update
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM docker.io/node:18.18.2-alpine
FROM docker.io/node:20.9.0-alpine

ARG APP_ROOT=/opt/app-root/src
ENV APP_PORT=8080 \
Expand All @@ -17,4 +17,4 @@ WORKDIR ${APP_ROOT}/app
RUN npm ci --omit=dev

EXPOSE ${APP_PORT}
CMD ["npm", "run", "start"]
CMD ["node", "./bin/www"]

0 comments on commit 374cdf6

Please sign in to comment.