Use isLatest db value in object search query #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimCsaky
requested review from
jujaga,
norrisng-bc and
jatindersingh93
as code owners
|
Code Climate has analyzed commit 862f097 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 64.7% (0.0% change). View more on Code Climate. |
jujaga
approved these changes
Oct 16, 2023
Coverage Report
|
jatindersingh93
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to update our search objects query to take advantage of the isLatest boolean we added to the db schema (previously we used createdAt date desc to work out latest).
This change fixes a bug where soft deleted files are showing up in bcbox.
Description
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments