Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cors exposed header for pagination counter #244

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

jatindersingh93
Copy link
Contributor

@jatindersingh93 jatindersingh93 commented Jan 19, 2024

This Change is part of the SC3467 and provide CORS access for header 'X-Total-Rows' for pagination counter.

SC3467

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codeclimate bot commented Jan 19, 2024

Code Climate has analyzed commit f897cbc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 66.4% (0.0% change).

View more on Code Climate.

Copy link

github-actions bot commented Jan 19, 2024

Coverage Report

Totals Coverage
Statements: 59.76% ( 2802 / 4689 )
Methods: 50.32% ( 319 / 634 )
Lines: 66.5% ( 1685 / 2534 )
Branches: 52.47% ( 798 / 1521 )

@jatindersingh93 jatindersingh93 marked this pull request as ready for review January 23, 2024 20:39
@TimCsaky TimCsaky merged commit 26bf9cc into master Jan 23, 2024
16 checks passed
@TimCsaky TimCsaky deleted the cors-header-exposed branch January 23, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants