Add source type 'web' so that siphon can suck up information from a website #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricksimonian
added
task: enhancement
|
@patricksimonian When a pull request (PR) is over the 200-400 line range (of change) the ability of the reviewer to effectively detect issues quickly diminishes. Your PR is over the preferred length of 300 lines set for this repo. While this cannot always be avoided, please be mindful of the reviewer's time by organizing your work into smaller, more manageable PRs. Here are a few thoughtful articles on what a good PR should look like: The Anatomy of a Perfect Pull Request Best Practices for Code Review Pro Tip
|
patricksimonian
force-pushed
the
imp/siphon-source-type-web
branch
from
1bde4a8
to
7af231e
Compare
patricksimonian
removed
the
status: not ready for merge
patricksimonian
force-pushed
the
imp/siphon-source-type-web
branch
from
357b6b2
to
bff8941
Compare
refactor schema validation
Refactor unfurl update tests due to unfurl function refactor add tests for unfurlWebURI fn . complete web source type unfurlWebURI also combines generic unfurl data fix lint
patricksimonian
force-pushed
the
imp/siphon-source-type-web
branch
from
bff8941
to
7226ca3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added another 'sourceType' to siphon called
webA web source type and takes a
urlproperty as its solesourcePropertiesThe url is unfurled and then created into a graphql node
Changes
web