Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UI: implement "Existing Business Information" component (step 1) - PART 1 #19264

Closed
7 of 8 tasks
JazzarKarim opened this issue Jan 12, 2024 · 9 comments
Closed
7 of 8 tasks
Assignees
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. UX Assurance

Comments

@JazzarKarim
Copy link
Collaborator

JazzarKarim commented Jan 12, 2024

Note: business lookup will search for both active and historical A companies.

See #19462, #15315 and #15524 descriptions for additional details, but Figma is source of truth.

@JazzarKarim JazzarKarim added the ENTITY Business Team label Jan 12, 2024
@JazzarKarim JazzarKarim changed the title Create UI: implement new Existing Business Information component Create UI: implement new Existing Business Information component for step 1 Jan 12, 2024
@severinbeauvais
Copy link
Collaborator

See #15314 description for possibly useful information.

@severinbeauvais severinbeauvais added the Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. label Apr 11, 2024
@severinbeauvais severinbeauvais changed the title Create UI: implement new Existing Business Information component for step 1 Create UI: implement "Existing Business Information" component (step 1) Apr 11, 2024
@severinbeauvais severinbeauvais changed the title Create UI: implement "Existing Business Information" component (step 1) Create UI: implement "Existing Business Information" component (step 1) - PART 1 Apr 16, 2024
@severinbeauvais severinbeauvais self-assigned this Apr 19, 2024
@severinbeauvais
Copy link
Collaborator

Test Notes

As part of this ticket, I replace duplicated code with a new MessageBox component. This affects the following:

  • message box when adding completing party to an incorporation application
  • message box when adding completing party to a registration
  • message box when adding a searched business or corporation to a registration
  • message box on horizontal/vertical amalgamation office addresses step
  • message box on first step of a voluntary dissolution
  • message box at top of firm dissolution

@severinbeauvais
Copy link
Collaborator

@yuisotozaki Ready for your assurance, please and thanks.

You can create your own (named) continuation in draft, or try this one: https://dev.create.business.bcregistry.gov.bc.ca/continuation-in-business-home?id=TmCY3xvKFc

  • try both options for existing business information (business search and manual entry)
  • try selecting Active and Historical A companies
  • try the validation (in this component, on this page, and app-wide)
  • see the data on the review page
  • try saving and resuming

If you see any needed changes, add a comment in this ticket, but I will fix them in #20889.

@yuisotozaki
Copy link
Collaborator

Observations - mostly errors in the design:

  1. Typo in the blurb; "extraprovincially" - the design was incorrect at the time of implementation

image.png

2. This should be "continuation application" - the design was incorrect at the time of implementation

image.png

3. This should be "continuation application" - the design was incorrect at the time of implementation

image.png

4. Food for thought. Since we allow selection of a historical record, we should make sure that the user is guided back to step 1 as if the step is incomplete so that they see the guidance to contact the B.C. Registries.

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Apr 29, 2024

Re: 4. Food for thought.

The component is not valid if a historical xpro is selected, so the Review page shows that the step is not finished, and the page shows the invalid section:

image

image

Were you thinking about more than this?

@yuisotozaki
Copy link
Collaborator

I think that makes sense. I'll ponder upon this further as we work towards step 5. I'd like to see the whole step 1 completed and see how it flows in these error cases.

@severinbeauvais
Copy link
Collaborator

I referenced your comments 1 through 3 in #20889. Can THIS ticket be moved to RFQA now?

@yuisotozaki
Copy link
Collaborator

Yes - Ready for QA.

@NaveenHebbale
Copy link
Collaborator

We showed in Sprint Demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. UX Assurance
Projects
None yet
Development

No branches or pull requests

4 participants