Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing validation messages #21137

Closed
10 tasks done
hfekete opened this issue May 3, 2024 · 5 comments
Closed
10 tasks done

Fix missing validation messages #21137

hfekete opened this issue May 3, 2024 · 5 comments
Assignees
Labels
BTR Business Transparency Register techdebt

Comments

@hfekete
Copy link
Collaborator

hfekete commented May 3, 2024

  • missing validation message on address -> country
  • validation message for address -> line 1 -- validation error message does not appear on blur
  • validation message doesn't clear for address -> all fields -- when filled by the line 1 selection error messages persist if they were there previously (errors are not updating from the selection. Probably related to ^)
  • birthdate validation message does not clear after date selection
  • changing citizenship removes all other validation messages on the form
  • tax number error validation is not triggered or cleared properly
    • on full form validation the input radio validation error is not shown
    • on update validation messages on both radios are not cleared correctly (the opposite radio will retain its error message)
  • if there are errors on fullname, when hitting "add my own info" error messages do not go away
  • the placeholder texts in some components do not turn red when there is an error. (citizenship, tax number input, and some input boxes in the address section)
@hfekete hfekete added the BTR Business Transparency Register label May 3, 2024
@mstanton1
Copy link
Collaborator

@hfekete to advise when updated form changes are in so @gunanagar can confirm which of these are outstanding, mark resolved issues, and update ticket to include any other validation issues found.

@gunanagar
Copy link
Collaborator

missing validation message on address -> country - Valid
validation message for address -> line 1 -- validation error message does not appear on blur - Valid
validation message doesn't clear for address -> all fields -- when filled by the line 1 selection error messages persist if they were there previously (errors are not updating from the selection. Probably related to ^)
birthdate validation message does not clear after date selection -Valid
changing citizenship removes all other validation messages on the form - Valid
tax number error validation is not triggered or cleared properly - Valid
on full form validation the input radio validation error is not shown - Valid
on update validation messages on both radios are not cleared correctly (the opposite radio will retain its error message) - Valid
if there are errors on fullname, when hitting "add my own info" error messages do not go away - Valid
the placeholder texts in some components do not turn red when there is an error. (citizenship, tax number input, and some input boxes in the address section) - Valid

@gunanagar
Copy link
Collaborator

@hfekete validation message doesn't clear for address -> all fields -- when filled by the line 1 selection error messages persist if they were there previously (errors are not updating from the selection. Probably related to ^) - FAIL

Screen Shot 2024-06-07 at 11.44.43 AM.png

@gunanagar
Copy link
Collaborator

@hfekete tested and looks good.

image.png

@gunanagar
Copy link
Collaborator

gunanagar commented Jun 10, 2024

Good

@fodiley fodiley closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BTR Business Transparency Register techdebt
Projects
None yet
Development

No branches or pull requests

4 participants