Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21137 - validation messages and styles #170

Merged
merged 10 commits into from
Jun 5, 2024
Merged

21137 - validation messages and styles #170

merged 10 commits into from
Jun 5, 2024

Conversation

hfekete
Copy link
Collaborator

@hfekete hfekete commented Jun 4, 2024

Issue:21137bcgov/entity#21137

Description of changes:

  • fixed validation messages mentioned in the ticket 21137
  • fixed style issues mentioned in 21137

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@hfekete hfekete self-assigned this Jun 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 24 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@433fcd1). Learn more about missing BASE report.

❗ Current head f3c1b1e differs from pull request most recent head c6fe8ec

Please upload reports for the commit c6fe8ec to get more accurate results.

Files Patch % Lines
btr-web/btr-main-app/utils/validation.ts 0.00% 13 Missing ⚠️
...omponents/individual-person/tax-info/TaxNumber.vue 50.00% 9 Missing ⚠️
...app/components/individual-person/add-new/index.vue 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage        ?   69.53%           
=======================================
  Files           ?       46           
  Lines           ?     3643           
  Branches        ?      211           
=======================================
  Hits            ?     2533           
  Misses          ?      906           
  Partials        ?      204
Flag Coverage Δ
btr-ui 69.53% <40.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hfekete
Copy link
Collaborator Author

hfekete commented Jun 4, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-btr-dev--pr-170-fy0bwih9.web.app

kialj876
kialj876 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Hrvoje, looks good. I think there's a commented out test for some of the validation messages? Also have a comment below if you agree

btr-web/btr-common-components/components/bcros/inputs/Address/Index.vue Outdated Show resolved Hide resolved
btr-web/btr-common-components/components/bcros/inputs/CountriesOfCitizenship/Index.vue Outdated
@@ -1,5 +1,6 @@
<template>
<UFormGroup
v-slot="{ error }"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very rarely have preference for readability, on short stuff like that so I will agree with you :D

btr-web/btr-common-components/components/bcros/inputs/DateSelect.vue Outdated Show resolved Hide resolved
btr-web/btr-common-components/components/bcros/inputs/NameField.vue Outdated Show resolved Hide resolved
@hfekete
Copy link
Collaborator Author

hfekete commented Jun 4, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-btr-dev--pr-170-fy0bwih9.web.app

@hfekete hfekete merged commit 54dbf07 into bcgov:main Jun 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kialj876 kialj876 kialj876 approved these changes

@patrickpeinanw patrickpeinanw Awaiting requested review from patrickpeinanw

Assignees

@hfekete hfekete

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hfekete @bcregistry-sre @kialj876