Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD- COOP-Legal API: should not process an AR correction #21672

Closed
severinbeauvais opened this issue Jun 6, 2024 · 6 comments
Closed

PROD- COOP-Legal API: should not process an AR correction #21672

severinbeauvais opened this issue Jun 6, 2024 · 6 comments
Assignees
Labels
bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Priority2

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jun 6, 2024

This bug was found while investigating #21650.

A correction to an Annual Report (or Conversion) is a "local filing" in Filings UI. It looks like this:

image.png

When this is filed, I believe it goes into a pending state, and staff (ops) needs to manually make the detailed corrections and then manually set the filing to complete.

However, the Legal API attemps to process this as a normal correction, so you get this (which probably never becomes unblocked because it does not contain the expected correction data):

image.png

@severinbeauvais severinbeauvais added bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Priority2 labels Jun 6, 2024
@severinbeauvais
Copy link
Collaborator Author

@OlgaPotiagalova @vysakh-menon-aot FYI. And I set it as P2 same as the other AR Correction ticket (21650).

@severinbeauvais
Copy link
Collaborator Author

An alternative to updating Legal API is to route users to the normal correction page (in Edit UI) when an AR (or Conversion) correction is needed. (In that case, it's an easy change in Filings UI.) I don't know if that will meet all business requirements.

@severinbeauvais
Copy link
Collaborator Author

See also details and screenshots in #21686.

@NaveenHebbale NaveenHebbale changed the title Legal API: should not process an AR correction COOP - Legal API: should not process an AR correction Jun 10, 2024
@NaveenHebbale NaveenHebbale changed the title COOP - Legal API: should not process an AR correction COOP - PROD- Legal API: should not process an AR correction Jun 10, 2024
@NaveenHebbale NaveenHebbale changed the title COOP - PROD- Legal API: should not process an AR correction PROD- COOP-Legal API: should not process an AR correction Jun 10, 2024
@severinbeauvais
Copy link
Collaborator Author

This ticket is blocked while awaiting the requirements.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Jun 19, 2024

According to #21846, we are disabling the ability to do a (local) Annual Report correction, so this ticket is obsolete.

@NaveenHebbale
Copy link
Collaborator

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Priority2
Projects
None yet
Development

No branches or pull requests

2 participants